Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negated flag config files #775

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Sep 14, 2022

Fix Issue #773
add some coverage tests

@phlptp phlptp added the bug label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 99.06% // Head: 99.19% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (e8e6c9c) compared to base (faea921).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e8e6c9c differs from pull request most recent head 10da196. Consider uploading reports for the commit 10da196 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   99.06%   99.19%   +0.12%     
==========================================
  Files          16       16              
  Lines        3964     3967       +3     
==========================================
+ Hits         3927     3935       +8     
+ Misses         37       32       -5     
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 99.48% <ø> (ø)
include/CLI/impl/Config_inl.hpp 99.15% <100.00%> (+<0.01%) ⬆️
include/CLI/Option.hpp 99.52% <0.00%> (+<0.01%) ⬆️
include/CLI/impl/App_inl.hpp 99.20% <0.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henryiii
Copy link
Collaborator

add some coverage tests

Yeah, we really need to get back to 100% - coverage much less useful when it's not 100%, because it can produce false positives.

@henryiii henryiii merged commit dcbcb47 into CLIUtils:main Sep 14, 2022
@henryiii henryiii deleted the negated_flag_config branch September 14, 2022 14:45
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Sep 14, 2022
@phlptp
Copy link
Collaborator Author

phlptp commented Sep 14, 2022

I think the switch to a compiled library(possibility) changed the code coverage. Looks like there are sections of missing coverage that are pretty old. Anyway getting back to 100% is going to be a long process.

@henryiii
Copy link
Collaborator

I think it mostly happened about a year ago when we lost Travis, new PRs stopped being checked for coverage so it started slipping. When I recently renabled it (before the compiled change), that's when I discovered the coverage had slipped. There might have been even more coverage losses due to the change, as well. :/

No rush, probably something we can work on once in a while.

@henryiii henryiii removed the needs README Needs to be mentioned in the README label Sep 14, 2022
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants