-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix catch2 3 support #980
Conversation
Definitely don't want to do that this Release, but at what point do we consider upping the minimum compiler support to C++14? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 4573 4573
=========================================
Hits 4573 4573 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
1ff0d88
to
ee53a1d
Compare
That's tricky, since "11" is in our name. :) I suppose it needs to be done at some point, though. Don't have a strong opinion, 14+ won't actually affect us too much, 17+ would be larger. 14+ would actually affect pybind11 more (which also has 11 in the name, and also hasn't increased it yet...) |
If we could go 23+ I'd use |
Most of my other code is running C++17 as min now, Might move some to C++20, this summer after Ubuntu 24.04 comes out. Not going to be able to move to 23, likely until at least late '26 |
Okay, maybe we can target moving to 17+ this year. Might see what pybind11 does, too, we could match that (even though they are completely unrelated, but it's simpler if the projects I maintain are similar ;) ) |
Is there an easy way to pre-install this in CI or download it (perhaps in meson)? It's bad that we aren't running in CI with version 3 (but don't want to drop 2, since we can't drop it until we drop C++11).