Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix catch2 3 support #980

Merged
merged 6 commits into from
Jan 12, 2024
Merged

tests: fix catch2 3 support #980

merged 6 commits into from
Jan 12, 2024

Conversation

henryiii
Copy link
Collaborator

Is there an easy way to pre-install this in CI or download it (perhaps in meson)? It's bad that we aren't running in CI with version 3 (but don't want to drop 2, since we can't drop it until we drop C++11).

@phlptp
Copy link
Collaborator

phlptp commented Jan 12, 2024

Definitely don't want to do that this Release, but at what point do we consider upping the minimum compiler support to C++14?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef327b7) 100.00% compared to head (ee53a1d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #980   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         4573      4573           
=========================================
  Hits          4573      4573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

henryiii and others added 6 commits January 12, 2024 17:11
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/tests/fixcatch3 branch from 1ff0d88 to ee53a1d Compare January 12, 2024 22:11
@henryiii
Copy link
Collaborator Author

That's tricky, since "11" is in our name. :) I suppose it needs to be done at some point, though. Don't have a strong opinion, 14+ won't actually affect us too much, 17+ would be larger. 14+ would actually affect pybind11 more (which also has 11 in the name, and also hasn't increased it yet...)

@henryiii
Copy link
Collaborator Author

If we could go 23+ I'd use std::result instead of exception handling. :)

@phlptp
Copy link
Collaborator

phlptp commented Jan 12, 2024

Most of my other code is running C++17 as min now, Might move some to C++20, this summer after Ubuntu 24.04 comes out. Not going to be able to move to 23, likely until at least late '26

@henryiii henryiii merged commit 20de8b7 into main Jan 12, 2024
54 checks passed
@henryiii henryiii deleted the henryiii/tests/fixcatch3 branch January 12, 2024 22:43
@henryiii
Copy link
Collaborator Author

Okay, maybe we can target moving to 17+ this year. Might see what pybind11 does, too, we could match that (even though they are completely unrelated, but it's simpler if the projects I maintain are similar ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants