Add confirm dialog to Remove Group button #529
Assignees
Labels
Comments
slaFFik
added a commit
that referenced
this issue
Dec 30, 2018
1 task
slaFFik
added a commit
that referenced
this issue
Dec 30, 2018
slaFFik
added a commit
that referenced
this issue
Dec 31, 2018
1) make confirmation ON by default 2) confirmation text is now configurable when defining the group field 3) remove newly added string from l10n JS object (not used anymore) 4) support a case when group field renderer was redefined and doesn't have `data-confirm` attribute at all 5) fix tests
slaFFik
changed the title
slaFFik
changed the title
lipemat
added a commit
to lipemat/CMB2
that referenced
this issue
Jan 4, 2019
* upstream/develop: make use of phpunit 6.5 for PHP 5.6. fix failing test for group removal confirmation message. Add props for CMB2#1208 Move the remove_confirm option to the example functions and leave default empty (to not break back-compat) Oops, fix typeof yoda check Fix removal confirmation in tests Simplify removal confirmation check Update typeof checks to use yoda make remove confirmation a bit more succinct Cannot use empty on an operation on older versions of php see CMB2#529 - improvements as per PR review: see CMB2#529 - fix tests with a default confirm value in DOM equal to no. fix CMB2#529 - Add confirm dialog to group Remove button. Add props for CMB2#1206 Add php tests npm script Add grunt watch npm script Add props for CMB2#1204 Ignore composer vendor dir fix CMB2#1205 - Package.json: fix the need of global (old) grunt. fix 1023 - Update PHPUnit version in composer.json. Add props for CMB2#1200 Remove superfluous method definitions Add develop class suffix to init.php class Bump version for hotfix release Fix issue when wp.data does not have core/editor. Check it first. Fixes CMB2#1197 Update version to 2.5.0 Update changelog Make install-wp-tests.sh executable Update tests to pass Add cmb_init_pickers and cmb_init_code_editors events for allowing just-in-time configuration for pickers/editors Make CMB2.getFields/CMB2.getFields more robust, allowing a filter callback, and specifying by field id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It worries me how easy it is to delete a group. Click and it's gone!
Can we get a confirm dialog in there?
At line 563 (in trunk today) make it like this for example:
if ( number > 1 && confirm('Are you sure')) {
Ideally of course, that message should be customisable, and the confirm itself should be optional.
Thanks
The text was updated successfully, but these errors were encountered: