Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WYSIWYG filed not working in a group #1361

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

yoren
Copy link
Contributor

@yoren yoren commented Jul 12, 2020

This PR fixes an issue where the WYSIWYG field isn't working in a group.

Description

When refactoring the WYSIWYG field in 7bb887c#diff-73510adb75ef05f23da2023345b5cf0dR49 the issue was introduced. 'wp-util', 'cmb2-wysiwyg' should be array( 'wp-util', 'cmb2-wysiwyg' ).

Motivation and Context

I use the wysiwyg field in a group and just noticed it stopped working, while it was working before.

Risk Level

I think the risk level should be low.

Testing procedure

Add a wysiwyg field to a group, it'll be displayed as a textarea, tinyMCE isn't initiated on it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@jtsternberg jtsternberg merged commit 965975d into CMB2:develop Jul 12, 2020
@jtsternberg
Copy link
Member

Good catch, thank you!

@yoren yoren deleted the develop-fix-wysiwyg-group-js branch July 12, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants