Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3082] CRA -> Vite migration #2163

Merged
merged 85 commits into from
Sep 11, 2023
Merged

Conversation

aterstriep
Copy link
Contributor

@aterstriep aterstriep commented Sep 1, 2023

EASI-3082

Changes and Description

  • Migrated from CRA to Vite
    • Env variables are now accessed with import.env instead of process.env
  • Migrated unit test runner from Jest to Vitest
    • The only real change to how we write our unit tests is using vi.mock, vi.fn, etc instead of jest.fn
    • Mocking the Okta sign-in widget is not supported in Vite, so these tests were removed since it's already covered in our e2e tests (Tests that use a canvas don't support threads in Vitest, so we removed the test in favor of being able to run the tests in a threaded environment for the sake of runtime)
    • Snapshots - updates were mostly small text and format changes (Ex: "Jest snapshot" text to "Vitest snapshot")
  • Updated dependencies to get rid of errors during migration:
    • Apollo
    • Cypress
    • Storybook
    • React-csv

Other Changes

Note: Running unit tests with threads turned off currently causes some tests to fail (bug explanation here)

How to test this change

  • Build app locally and make sure everything works as expected
  • Run unit tests
  • Run e2e tests

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball temporarily deployed to test September 6, 2023 20:59 — with GitHub Actions Inactive
@patrickseguraoddball patrickseguraoddball temporarily deployed to test September 6, 2023 21:23 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to test September 7, 2023 14:38 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to test September 7, 2023 15:58 — with GitHub Actions Inactive
…to transform require to import in imported modules
@ClayBenson94 ClayBenson94 temporarily deployed to test September 7, 2023 16:46 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to test September 7, 2023 17:41 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to test September 8, 2023 17:44 — with GitHub Actions Inactive
ClayBenson94
ClayBenson94 previously approved these changes Sep 8, 2023
@aterstriep aterstriep temporarily deployed to test September 11, 2023 14:25 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev September 11, 2023 15:14 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to test September 11, 2023 15:24 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev September 11, 2023 15:24 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev_gate September 11, 2023 15:42 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev September 11, 2023 15:42 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev September 11, 2023 15:45 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 temporarily deployed to dev September 11, 2023 15:45 — with GitHub Actions Inactive
@ClayBenson94 ClayBenson94 merged commit a545d93 into main Sep 11, 2023
39 checks passed
@ClayBenson94 ClayBenson94 deleted the EASI-3082/migrate-cra-to-vite-2 branch September 11, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants