-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASI-3082] CRA -> Vite migration #2163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move index.html to root folder - Remove %PUBLIC_URL% references - Add Vite entry point
- Remove react-scripts - Delete react-app-env.d.ts
Not necessary for vite migration, but removed warning message to update.
Previous version was incompatible with Vite because Link component was .js file instead of .jsx
Error: Uncaught [TypeError: Cannot read properties of null (reading 'offsetWidth')]
Multiple installed versions of vite was causing type error
patrickseguraoddball
temporarily deployed
to
test
September 6, 2023 20:59
— with
GitHub Actions
Inactive
patrickseguraoddball
temporarily deployed
to
test
September 6, 2023 21:23
— with
GitHub Actions
Inactive
ClayBenson94
force-pushed
the
EASI-3082/migrate-cra-to-vite-2
branch
from
September 7, 2023 14:37
440c782
to
e1a4397
Compare
…to transform require to import in imported modules
ClayBenson94
previously approved these changes
Sep 8, 2023
ClayBenson94
temporarily deployed
to
dev_gate
September 11, 2023 15:42
— with
GitHub Actions
Inactive
ClayBenson94
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-3082
Changes and Description
import.env
instead ofprocess.env
vi.mock
,vi.fn
, etc instead ofjest.fn
canvas
don't support threads in Vitest, so we removed the test in favor of being able to run the tests in a threaded environment for the sake of runtime)Other Changes
node_modules
) paths. A notable change is in https://github.com/CMSgov/easi-app/blob/1430664e318f3a875c9c30c5cffccb7c2a9fa32c/src/index.scss, where the import statement for okta-signin-widget was changed.webpack
. There were issues trying to get Cypress to work with Vite usingcypress-vite
Note: Running unit tests with threads turned off currently causes some tests to fail (bug explanation here)
How to test this change
PR Author Review Checklist
PR Reviewer Guidelines