Install snyk and set up yml file to integrate into CI/CD #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelynnchen-cmu
requested changes
Oct 31, 2024
There was a problem hiding this comment.
PR is not passing linter due to a failing test case at test/topics/thumbs.js:361:11. Since this test seems like it doesn't apply to any code changes our team made, I'd comment out the test then rerun the test suite to try to pass the linter. I'm also not sure why topics/create.js is being added, seems like a file from Project 2. Make sure your branch is up to date with f24 before making another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed snyk, which can be clearly seen in
package.json. Snyk enhances application security by scanning code, dependencies, containers, and infrastructure files for vulnerabilities, continuously monitoring them, and suggesting automated fixes.I have also already set up
snyk.ymlin .github/workflows and integrate into CI/CD. The evidence of it running is here