Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool 1 (Analysis that is not in starter list): Integrated Complexity-Report into our CI/CD pipeline #44

Open
wants to merge 1 commit into
base: f24
Choose a base branch
from
Open

Tool 1 (Analysis that is not in starter list): Integrated Complexity-Report into our CI/CD pipeline #44

wants to merge 1 commit into from

Conversation

joeni21
Copy link

@joeni21 joeni21 commented Oct 24, 2024 •
edited
Loading

Integrated Complexity-Report Static Analysis Tool

Evidence it was installed (screenshot below):
Screenshot 2024-10-24 at 12 29 14 PM

The above screenshot shows that it has been added to our package.json file as well.

Evidence the tool was run on the repository: https://github.com/CMU-313/nodebb-f24-team-five-guys/pull/44/files

@joeni21 joeni21 added the enhancement New feature or request label Oct 24, 2024
@joeni21 joeni21 self-assigned this Oct 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11503648799

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.707%
Totals Coverage Status
Change from base Build 11500290722: 0.0%
Covered Lines: 22356
Relevant Lines: 25612
💛 - Coveralls

@paulinezhanghh paulinezhanghh changed the title Integrated Complexity-Report into our git flow as a static analysis tool Tool 1: Integrated Complexity-Report into our git flow as a static analysis tool Oct 24, 2024
@LeeMEow23 LeeMEow23 added this to the Project 3 milestone Oct 24, 2024
@joeni21 joeni21 changed the title Tool 1: Integrated Complexity-Report into our git flow as a static analysis tool Tool 1: Integrated Complexity-Report into our git flow as a static analysis tool not in starter list Oct 24, 2024
@LeeMEow23 LeeMEow23 changed the title Tool 1: Integrated Complexity-Report into our git flow as a static analysis tool not in starter list Tool 1(not in starter list): Integrated Complexity-Report into our CI/CD pipeline Oct 24, 2024
@LeeMEow23 LeeMEow23 changed the title Tool 1(not in starter list): Integrated Complexity-Report into our CI/CD pipeline Tool 1 (Analysis that is not in starter list): Integrated Complexity-Report into our CI/CD pipeline Oct 24, 2024
@e5z26 e5z26 self-requested a review October 24, 2024 21:13
LeeMEow23
LeeMEow23 requested changes Oct 24, 2024
View reviewed changes
Copy link

@LeeMEow23 LeeMEow23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justin, would you mind changing your PR's description to follow Ethan's PR description format? having 2 separate links for the required evidence. The rest looks all good, thanks!

@e5z26 e5z26 removed their request for review October 24, 2024 21:41
LeeMEow23
LeeMEow23 reviewed Oct 24, 2024
View reviewed changes
Copy link

@LeeMEow23 LeeMEow23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions looks clear to me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeMEow23 LeeMEow23 LeeMEow23 requested changes

Assignees

@joeni21 joeni21

Labels
Analysis Tools enhancement New feature or request
Projects
None yet
Milestone
Project 3
Development

Successfully merging this pull request may close these issues.
3 participants
@joeni21 @coveralls @LeeMEow23