Integrated JSHint into the CI/CD Pipeline #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the configuration file, and edited the package.json and test.ymal file to run the test for JSHint.
revised the indentation and extra blank spaces
added a space for "- name"
Changed the esversion form 6 to 8.
Changed the esversion from 8 to 9
defined 2 more attributes in the configuration file to pass the test
adjusted the style in 2 js files to pass the JSHint test.
…b-f24-team-five-guys into jshint_integration
changed all the "!" to "=== false" for some of the if statements to match the style requirements for JSHint.
Renamed Option to ProgramOption as what is defined at the beginning of the file.
In the previous changes we made, the logic of one of the if statements has been falsely changed. We revised that this time.
Pull Request Test Coverage Report for Build 11577937196Details
💛 - Coveralls |
joeni21
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the configuration file, and edited the package.json and test.ymal file to run the test for JSHint.