Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US2 - Add checkbox + backend update to read if checked or not #40

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

shantinghou
Copy link

@shantinghou shantinghou commented Sep 19, 2024

What

Improved checkbox implementation in the frontend for posting a topic anonymously and linked it to the backend so that backend can read the checkbox values (whether it's been ticked or not)

Why

Complete issue 2 for user story 2.

How

Changes were made in nodebb-plugin-composer-default and javascript files that handle API calls and Topic and Post classes so that "postAnonymous" field is added to the backend models.

Testing

No testing were made yet other than from testing the front end locally and via debug logs.

Screenshots

Screenshot 2024-09-19 at 10 31 03 AM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10943304446

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.688%

Totals Coverage Status
Change from base Build 10912290124: 0.0%
Covered Lines: 22330
Relevant Lines: 25585

💛 - Coveralls

@guanjiecheng guanjiecheng merged commit 606ce45 into f24 Sep 19, 2024
1 check passed
@shantinghou shantinghou added the enhancement New feature or request label Oct 6, 2024
@shantinghou shantinghou added this to the Sprint 1 milestone Oct 6, 2024
@shantinghou shantinghou self-assigned this Oct 6, 2024
@shantinghou shantinghou modified the milestones: Sprint 1, Sprint 2 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anonymous enhancement New feature or request
Projects
None yet
4 participants