Chore/mobile/refactor #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: 16 passed, 16 total
This commit adds an authentication check before making the API call to fetch user bookings. If the authentication token is not found, an error response is returned with the appropriate error code and message.
Tests: 13 passed, 13 total Snapshots: 0 total Time: 4.245 s
…2024/occupi into chore/mobile/refactor
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13149987 | Triggered | Generic Password | 7ba4f7f | frontend/occupi-mobile4/services/authservices.ts | View secret |
| 13149987 | Triggered | Generic Password | 5c4f173 | frontend/occupi-mobile4/services/authservices.ts | View secret |
| 13149987 | Triggered | Generic Password | 81dfca9 | frontend/occupi-mobile4/services/authservices.ts | View secret |
| 13149987 | Triggered | Generic Password | 908a89c | frontend/occupi-mobile4/services/authservices.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces a refactored mobile with a file structure that makes the system more readable. It includes an update to storage of the different data such as user data, user settings, as well as the current state of the app for state management. (this will allow rollbacking to a stable state should there be any issues. This pr also introduces the setting of profile details upon registering a new account, however there is a small issue ther that will be addressed in due time.
It also includes multiple fixes including:
Fixes #272, #241
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: