Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/mobile/refactor2 #278

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Chore/mobile/refactor2 #278

merged 2 commits into from
Aug 6, 2024

Conversation

KamogeloMoeketse
Copy link
Contributor

Description

This PR intoduces the changes from #277.

This pr introduces a refactored mobile with a file structure that makes the system more readable. It includes an update to storage of the different data such as user data, user settings, as well as the current state of the app for state management. (this will allow rollbacking to a stable state should there be any issues. This pr also introduces the setting of profile details upon registering a new account, however there is a small issue ther that will be addressed in due time.

It also includes multiple fixes including:

updating of profile details
updating theme and accent colours
added ThemeContext
Fixes #272, #241

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@KamogeloMoeketse KamogeloMoeketse added type: chore Just a cleanup or minor update effort: 5 This may require/required hours of work labels Aug 6, 2024
@KamogeloMoeketse KamogeloMoeketse self-assigned this Aug 6, 2024
Copy link

gitguardian bot commented Aug 6, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13149987 Triggered Generic Password c30caae frontend/occupi-mobile4/services/authservices.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@KamogeloMoeketse KamogeloMoeketse merged commit 905f323 into develop Aug 6, 2024
1 of 3 checks passed
waveyboym pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work type: chore Just a cleanup or minor update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]Fix Appearance Settings
1 participant