Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fic Location-based check-in prompt #326

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

KamogeloMoeketse
Copy link
Contributor

@KamogeloMoeketse KamogeloMoeketse commented Aug 20, 2024

Description

This pr introduces the fix for the Point-in-polygon algorithm to work as it should.

Fixes #325

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@KamogeloMoeketse KamogeloMoeketse added type: fix Introduces a fix for a previous issue effort: 2 This can be/was resolved in minutes but requires/required shallow engagement platform: mobile This is related to mobile platforms labels Aug 20, 2024
@KamogeloMoeketse KamogeloMoeketse self-assigned this Aug 20, 2024
@KamogeloMoeketse KamogeloMoeketse merged commit 32d18ff into develop Aug 20, 2024
4 checks passed
@KamogeloMoeketse KamogeloMoeketse deleted the fix/mobile/location branch August 20, 2024 17:34
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.07%. Comparing base (d923624) to head (132374c).
Report is 3 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (d923624) and HEAD (132374c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d923624) HEAD (132374c)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #326       +/-   ##
============================================
- Coverage    73.28%   33.07%   -40.22%     
============================================
  Files           52       11       -41     
  Lines         3126      517     -2609     
  Branches        76       76               
============================================
- Hits          2291      171     -2120     
+ Misses         762      319      -443     
+ Partials        73       27       -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 This can be/was resolved in minutes but requires/required shallow engagement platform: mobile This is related to mobile platforms type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]Fix location algorithm
1 participant