Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/testing mobile #328

Merged
merged 16 commits into from
Aug 21, 2024
Merged

Task/testing mobile #328

merged 16 commits into from
Aug 21, 2024

Conversation

u21631532
Copy link
Contributor

Pull Request Template

Description

Tests for mobile

Fixes # (#130 & #39 )

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@u21631532 u21631532 added type: testing This affects one or more tests For: frontend This is mainly related to frontend UI code priority: high This needs/needed to be addressed as soon as possible effort: 8 This may require/required a week of work at minimum platform: mobile This is related to mobile platforms labels Aug 21, 2024
@u21631532 u21631532 added this to the Week 1 Sprint 4 milestone Aug 21, 2024
@u21631532 u21631532 self-assigned this Aug 21, 2024
@u21631532 u21631532 merged commit 996a6b3 into develop Aug 21, 2024
4 checks passed
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 51.61290% with 15 lines in your changes missing coverage. Please review.

Project coverage is 69.59%. Comparing base (32d18ff) to head (7453626).
Report is 17 commits behind head on develop.

Files Patch % Lines
frontend/occupi-mobile4/utils/bookings.ts 57.89% 6 Missing and 2 partials ⚠️
frontend/occupi-mobile4/utils/notifications.ts 30.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
- Coverage    73.28%   69.59%   -3.70%     
===========================================
  Files           52       11      -41     
  Lines         3126      523    -2603     
  Branches        76       81       +5     
===========================================
- Hits          2291      364    -1927     
+ Misses         762      118     -644     
+ Partials        73       41      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 8 This may require/required a week of work at minimum For: frontend This is mainly related to frontend UI code platform: mobile This is related to mobile platforms priority: high This needs/needed to be addressed as soon as possible type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant