Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mobile/forgot password #346

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

KamogeloMoeketse
Copy link
Contributor

Description

This pr introduces the forgot password feature, now fully integrated with the backend, which allows user to enter the email address associated with their account and the ability to veriofy the otp and input a new password.

Fixes #345

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@KamogeloMoeketse KamogeloMoeketse added effort: 5 This may require/required hours of work platform: mobile This is related to mobile platforms For: integration This is for work involving integration with the backend/model API labels Aug 27, 2024
@KamogeloMoeketse KamogeloMoeketse self-assigned this Aug 27, 2024
Copy link

gitguardian bot commented Aug 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13149987 Triggered Generic Password 79ae407 frontend/occupi-mobile4/services/authservices.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 66.84%. Comparing base (6bafd23) to head (5c0b9bd).
Report is 10 commits behind head on develop.

Files Patch % Lines
frontend/occupi-mobile4/services/authservices.ts 4.54% 21 Missing ⚠️
frontend/occupi-mobile4/services/securestore.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6bafd23) and HEAD (5c0b9bd). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (6bafd23) HEAD (5c0b9bd)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #346       +/-   ##
============================================
- Coverage    83.83%   66.84%   -16.99%     
============================================
  Files           53       11       -42     
  Lines         3143      546     -2597     
  Branches        81       84        +3     
============================================
- Hits          2635      365     -2270     
+ Misses         425      140      -285     
+ Partials        83       41       -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KamogeloMoeketse KamogeloMoeketse merged commit 2f3fdbf into develop Aug 27, 2024
4 of 6 checks passed
@KamogeloMoeketse KamogeloMoeketse deleted the feat/mobile/forgot-password branch September 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: integration This is for work involving integration with the backend/model API platform: mobile This is related to mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]Forgot Password Mobile
1 participant