Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transport through straits notebook + use pint #250

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Feb 14, 2023

@aidanheerdegen I used pint here. I defined a new unit Sverdrup. Unfortunately I couldn't define it as Sv or give it this alias because that's the symbol for Sievert.

But all right, oceanographers most of the times want Sverdrup and not Sieverts (unless there is a Fukushima-type of situation). How can we redefine Sv to mean Sverdrup?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy navidcy added the 🛸 updating An existing notebook needs to be updated label Feb 14, 2023
@navidcy
Copy link
Collaborator Author

navidcy commented Feb 15, 2023

ok, if all looks good perhaps I can have your approval?

test/test_notebooks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now

@navidcy
Copy link
Collaborator Author

navidcy commented Feb 15, 2023

nice catch ;)

@navidcy navidcy merged commit 2379f02 into master Feb 15, 2023
@navidcy navidcy deleted the ncc/transport branch February 15, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛸 updating An existing notebook needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants