-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intake conversion Cross-contour_transport #356
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@taimoorsohail just checking: the |
I thought I pushed from taimoorsohail:main to Cosima-recipes:main? Either way, no, I wasn't trying to push in this branch. I was reviewing this PR request but there are significant bugs in the Cross-contour_transport code (not related to this PR - they are well documented in other issues), so I think @adele-morrison is ironing out those bugs. |
Your local clone must have had some edits from previous things you'd be working on and then you did something like That's a guess. I'll sort it out -- don't worry! :) |
I don't understand exactly what do you mean. Nobody is allowed to push to This PR was opened from a branch of Anyway I fixed it... I'm just trying to make it easier for other times but I'm not sure if I'm explaining myself properly. [I do admit that it's early am, I'm jet lagged and coffee shops are closed where I currently am! :)] |
I got about halfway through merging the updates from the trunk (PR #423) yesterday, but now can't continue without Gadi access. Whilst doing that, I identified a potential issue with the Intake catalogue of the dataset being used: ACCESS-NRI/access-nri-intake-catalog#192 |
I've completed merging the latest |
Actually could you request review from somebody else? There are many COSIMAers who would be willing to contribute. |
@adele-morrison are you in a position to be able to review this, and if not, could you suggest someone who is? |
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.