Improve handling of vertical grid, adding support for MOM6 grids #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@aekiss Would you mind having a quick look? There's a lot of stuff going on, but would be good to know if the documentation is okay. |
micaeljtoliveira
force-pushed
the
refactor_vgrid
branch
from
7b1d5ea
to
1c3673a
Compare
aekiss
reviewed
Sep 18, 2024
aekiss
reviewed
Sep 18, 2024
aekiss
previously approved these changes
Sep 18, 2024
aekiss
reviewed
Sep 18, 2024
aekiss
reviewed
Sep 18, 2024
…e grids have only n+1 cell boundaries instead of the 2n+1 interleaved cell boundaries and centres of the MOM5 grids.
micaeljtoliveira
force-pushed
the
refactor_vgrid
branch
from
1c3673a
to
f651e5a
Compare
|
@aekiss Thanks for the review! I think I fixed everything. Have a look and please approve if you think it's good to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for MOM6 vertical grids. The type of grid used is controlled via a command line option.
Closes #33