Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: debounce_timeout compare different iterators #743

Closed
wennmbj opened this issue Jul 17, 2024 · 1 comment
Closed

[BUG]: debounce_timeout compare different iterators #743

wennmbj opened this issue Jul 17, 2024 · 1 comment
Labels

Comments

@wennmbj
Copy link
Contributor

wennmbj commented Jul 17, 2024

vSomeip Version

v3.4.10

Boost Version

1.74

Environment

Ubuntu 22.04

Describe the bug

In function: routing_manager_base::debounce_timeout_update_cbk the if condition: if (_event && (_event->get_subscribers().find(_client) != _event->get_subscribers().end()) && _filter) does not work properly. Here get_subscribers() return a copy of a set with each call. So the objects will never be equal here _event->get_subscribers().find(_client) != _event->get_subscribers().end())
My PR: #739 fixes the issue, but get_subscribers() should be refactored to return a reference instead a copy.

Reproduction Steps

No response

Expected behaviour

No response

Logs and Screenshots

No response

@wennmbj wennmbj added the bug label Jul 17, 2024
@wennmbj
Copy link
Contributor Author

wennmbj commented Aug 9, 2024

Pull request will be closed since this change will be added here: 2ad557f

@duartenfonseca duartenfonseca pinned this issue Aug 27, 2024
@duartenfonseca duartenfonseca unpinned this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants