fix: debounce_timeout compare different iterators #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function get_subscriber() returns a copy of the set (not a reference). A new copy is returned on every call. Therefore, the comparison happens between iterators of two different copies of the set - which will never be equal. Generally the get_subscriber should be refactored to return a reference instead of copy.
|
this pull request will be closed since this change will be added here: 2ad557f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function get_subscriber() returns a copy of the set (not a reference). A new copy is returned on every call. Therefore, the comparison happens between iterators of two different copies of the set - which will never be equal. Generally the get_subscriber should be refactored to return a reference instead of copy.