fix: angle is now a struct and emitted as a rotation
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be brought up to date with CQCL/tket2#611 before merging |
mark-koch
reviewed
Sep 15, 2024
doug-q
force-pushed
the
ss/fix-angle-lower
branch
from
e14431f
to
ba5736b
Compare
doug-q
changed the title
angle is now a struct and emitted as a rotation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 91.59% 91.67% +0.07%
==========================================
Files 60 59 -1
Lines 6152 6138 -14
==========================================
- Hits 5635 5627 -8
+ Misses 517 511 -6 ☔ View full report in Codecov by Sentry. |
acl-cqc
reviewed
Sep 17, 2024
| [mb_rotation] = self.builder.add_op(from_halfturns(), halfturns) | ||
|
|
||
| conditional = self.builder.add_conditional(mb_rotation) | ||
| with conditional.add_case(0) as case: |
There was a problem hiding this comment.
Not really for this PR, but somewhere in guppy we should have a build_unwrap helper that does this faffing with a conditional two cases, a passthrough and a panic...
acl-cqc
reviewed
Sep 17, 2024
| try: | ||
| import execute_llvm | ||
|
|
||
| if not hasattr(execute_llvm, "run_int_function"): | ||
| fn = getattr(execute_llvm, run_fn_name) | ||
| if not fn: | ||
| pytest.skip("Skipping llvm execution") |
There was a problem hiding this comment.
Suggested change
| pytest.skip("Skipping llvm execution") | |
| pytest.skip(f"Skipping llvm execution, {run_fn_name} not found") |
Note we've already checked for execute_llvm not being imported, so we don't really expect this to fail (do we?)
acl-cqc
approved these changes
Sep 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.0...v0.12.0) (2024-09-18) ### ⚠ BREAKING CHANGES * Pytket circuits loaded via a `py` expression no longer take ownership of the passed qubits. * Lists and function tensors are no longer available by default. `guppylang.enable_experimental_features()` must be called before compilation to enable them. * The `GuppyModule` argument is now optional for all decorators and no longer the first positional argument. Removed the explicit module objects `builtins`, `quantum`, and `angle`. * `quantum_functional` is now its own Guppy module and no longer implicitly comes with `quantum`. * Linear function arguments are now borrowed by default; removed the now redundant `@inout` annotation ### Features * Add functions to quantum module and make quantum_functional independent ([#494](#494)) ([0b0b1af](0b0b1af)) * Hide lists and function tensors behind experimental flag ([#501](#501)) ([c867f48](c867f48)) * Make linear types [@inout](https://github.com/inout) by default; add [@owned](https://github.com/owned) annotation ([#486](#486)) ([e900c96](e900c96)) * Only lower definitions to Hugr if they are used ([#496](#496)) ([cc2c8a4](cc2c8a4)) * Support implicit modules for all decorators and turn builtins into implicit module ([#476](#476)) ([cc8a424](cc8a424)) * Use inout for pytket circuits ([#500](#500)) ([a980ec2](a980ec2)) ### Bug Fixes * `angle` is now a struct and emitted as a rotation ([#485](#485)) ([992b138](992b138)) * Evade false positives for inout variable usage ([#493](#493)) ([6fdb5d6](6fdb5d6)) * Fix redefinition of structs ([#499](#499)) ([0b156e9](0b156e9)) * Initialise _checked in GuppyModule ([#491](#491)) ([3dd5dd3](3dd5dd3)), closes [#489](#489) * use correct array ops ([#503](#503)) ([720d8b8](720d8b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update extension definitions and lower angle type to rotation.