Skip to content

Commit

Permalink
remove negative rule
Browse files Browse the repository at this point in the history
it doesn't seem to work, the filter always returs `true`
if we add something like

  - '!**/*.md'
  • Loading branch information
aborgna-q committed Mar 18, 2024
1 parent 2ec0f2b commit 230e625
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci-py.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@ jobs:
python: ${{ github.ref_name == github.event.repository.default_branch || steps.filter.outputs.python }}
steps:
# For pull requests it's not necessary to checkout the code
- if: github.ref_name != github.event.repository.default_branch
uses: dorny/paths-filter@v3
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
python:
- 'quantinuum-hugr-py/**'
- 'pyproject.toml'
- '!**/*.md'
check:
needs: changes
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ci-rs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,14 @@ jobs:
rust: ${{ github.ref_name == github.event.repository.default_branch || steps.filter.outputs.rust }}
steps:
# For pull requests it's not necessary to checkout the code
- if: github.ref_name != github.event.repository.default_branch
uses: dorny/paths-filter@v3
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
rust:
- 'quantinuum-hugr/**'
- 'specification/schema/**'
- 'Cargo.toml'
- '!**/*.md'
- 'specification/schema/**'
check:
needs: changes
Expand Down

0 comments on commit 230e625

Please sign in to comment.