Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __repr__ for all Type and Op subclasses #1468

Closed
mark-koch opened this issue Aug 27, 2024 · 0 comments · Fixed by #1482
Closed

Implement __repr__ for all Type and Op subclasses #1468

mark-koch opened this issue Aug 27, 2024 · 0 comments · Fixed by #1482
Assignees
Labels
python Pull requests that update Python code

Comments

@mark-koch
Copy link
Contributor

Otherwise, the new dot visualisation from #1462 is completely unreadable

@mark-koch mark-koch added the python Pull requests that update Python code label Aug 27, 2024
@ss2165 ss2165 self-assigned this Aug 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 30, 2024
Closes #1468 
Closes #1470

Previous testing wasn't covering label formatting because it requires
actually rendering the dot in to an image. Have enabled that, but put it
behind an env var because it significantly slows down tests.

BREAKING CHANGE: rename `Custom.name` to `Custom.op_name` and
`Func(Defn/Decl).name` to `f_name` to allow for new `name` method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants