Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle should always assume maximum precision #608

Closed
ss2165 opened this issue Sep 10, 2024 · 0 comments · Fixed by #611
Closed

Angle should always assume maximum precision #608

ss2165 opened this issue Sep 10, 2024 · 0 comments · Fixed by #611
Assignees
@ss2165
Labels
enhancement New feature or request

Comments

@ss2165
Copy link
Member

ss2165 commented Sep 10, 2024

Then a single u64 to specify the numerator is isomorphic.
No need to track lower log_denom.
Smallest denominator rational calculation can be performed by library functions.
@ss2165 ss2165 added the enhancement New feature or request label Sep 10, 2024
@ss2165 ss2165 mentioned this issue Sep 13, 2024
Merged
@ss2165 ss2165 self-assigned this Sep 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 16, 2024
@ss2165 @doug-q
feat!: simplify angle extension in to a half turns rotation type (#611)
0723937 
Closes #610
Closes #608
Closes #605


BREAKING CHANGE: "tket2.angle" extension replaced with "tket2.rotation"
extension with rotation type and simplified set of operations.

---------

Co-authored-by: Douglas Wilson <141026920+doug-q@users.noreply.github.com>
Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: simplify angle extension in to a half turns rotation type CQCL/tket2
1 participant
@ss2165