Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map missing from extension panel #59

Closed
ctriquet-cs opened this issue Jan 6, 2022 · 1 comment · Fixed by #60
Closed

Map missing from extension panel #59

ctriquet-cs opened this issue Jan 6, 2022 · 1 comment · Fixed by #60

Comments

@ctriquet-cs
Copy link
Collaborator

The fix provided to issue #56 by commit 4100448 actually introduces a regression.

On a fresh Python environment, when running eodag-labextension into JupyterLab, the search extend dedicated map is missing.

image
@ctriquet-cs
Copy link
Collaborator Author

This is fixed by installing ipyleaflet (what is not a solution).
Actually, the CSS class .leaflet-container has no size. Installing ipyleaflet provides a dimension to that CSS class.

ctriquet-cs added a commit that referenced this issue Jan 6, 2022
@ctriquet-cs
fix: set leaflet container size fix #59
f24da8f
@ctriquet-cs ctriquet-cs linked a pull request Jan 7, 2022 that will close this issue
fix: set leaflet container size fix #59 #60
Merged
@sbrunato sbrunato mentioned this issue Jan 7, 2022
Merged
@sbrunato sbrunato closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set leaflet container size fix #59 CS-SI/eodag-labextension
2 participants
@ctriquet-cs @sbrunato