Import Export feature #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make various changes to PorterManager
Also add DeckImportException
Refactor methods to take in String instead of Path
Now returns a String so user can tell where the file is exported to
Import and Export commands and functions are working
|
Resolves #57 |
And Formatting
thanh-ntt
approved these changes
Oct 29, 2018
|
|
||
| Deck deckToExport = lastShownList.get(targetIndex.getZeroBased()); | ||
| String exportPath = model.exportDeck(deckToExport); | ||
| System.out.println(exportPath); |
There was a problem hiding this comment.
Is this for debugging?
Suggested change
| System.out.println(exportPath); |
| @@ -57,6 +57,10 @@ | |||
|
|
|||
| boolean isInsideDeck(); | |||
|
|
|||
| String exportDeck(Deck deck); | |||
|
|
|||
| Deck importDeck (String filepath); | |||
There was a problem hiding this comment.
Suggested change
| Deck importDeck (String filepath); | |
| Deck importDeck(String filepath); |
|
As you add some more methods to existing classes, it would be nice if you can change the test classes to cover those new methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a PortManager class to handle reading and writing of data to/from files. Uses XmlUtil
Anakin now contains a PortManager
The default location for export/import is the root folder normally called "main". (Same folder as README.adoc)
Includes PortManager, Commands, Parser, Unit Tests.
Todo: Integrated testing