Change XML file from the original person data to calendar event data, Fix SelectCommandSystemTest #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/seedu/address/ui/TaskListPanelTest.java # src/test/java/seedu/address/ui/ToDoListEventCardTest.java # src/test/java/systemtests/AddEventCommandSystemTest.java # src/test/java/systemtests/ClearCalendarCommandSystemTest.java # src/test/java/systemtests/DeleteEventCommandSystemTest.java # src/test/java/systemtests/EditEventCommandSystemTest.java # src/test/java/systemtests/FindEventCommandSystemTest.java # src/test/java/systemtests/HelpCommandSystemTest.java # src/test/java/systemtests/SelectCommandSystemTest.java
# Conflicts: # src/test/java/seedu/address/ui/TaskListPanelTest.java # src/test/java/seedu/address/ui/ToDoListEventCardTest.java # src/test/java/systemtests/AddEventCommandSystemTest.java # src/test/java/systemtests/ClearCalendarCommandSystemTest.java # src/test/java/systemtests/DeleteEventCommandSystemTest.java # src/test/java/systemtests/EditEventCommandSystemTest.java # src/test/java/systemtests/FindEventCommandSystemTest.java # src/test/java/systemtests/HelpCommandSystemTest.java # src/test/java/systemtests/SelectCommandSystemTest.java
bryanwongweiheng
changed the title
Pull Request Test Coverage Report for Build 261
💛 - Coveralls |
# Conflicts: # src/main/java/seedu/address/logic/commands/Command.java # src/main/java/seedu/address/model/calendarevent/DateTime.java # src/main/resources/view/DarkTheme.css # src/main/resources/view/MainWindow.fxml # src/main/resources/view/ToDoListEventCard.fxml
TODO: refactor MainWindow (it has too many responsibilities now)
|
seems good to merge |
vig42
reviewed
Nov 7, 2018
| throw new AssertionError(e); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Just a random qn, why are so many edits just adding and deleting the same things?
vig42
reviewed
Nov 7, 2018
| + DESCRIPTION_DESC_TUTORIAL + START_DESC_TUTORIAL + END_DESC_TUTORIAL | ||
| + VENUE_DESC_TUTORIAL + TAG_DESC_HUSBAND + TAG_DESC_FRIEND; | ||
| + DESCRIPTION_DESC_TUTORIAL + START_DESC_TUTORIAL + END_DESC_TUTORIAL | ||
| + VENUE_DESC_TUTORIAL + TAG_DESC_HUSBAND + TAG_DESC_FRIEND; |
There was a problem hiding this comment.
We should probably (eventually) replace the TAG_DESC_HUSBAND and TAG_DESC_FRIEND to something more relevant, like PROJECT or something.
vig42
reviewed
Nov 7, 2018
| TagsPredicate tagsPredicate = prepareTagsPredicate(""); | ||
| FindEventCommand command = new FindEventCommand(predicate, comparator, tagsPredicate); | ||
| expectedModel.updateFilteredCalendarEventList(predicate); | ||
| expectedModel.sortFilteredCalendarEventList(comparator); // added because FindEventCommand sorts as well | ||
| assertCommandSuccess(command, model, commandHistory, expectedMessage, expectedModel); | ||
| assertEquals(Arrays.asList(CARL, ELLE, FIONA), model.getFilteredCalendarEventList()); |
There was a problem hiding this comment.
These 3 should also eventually be renamed as events. Maybe can put as a TODO?
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regressions caused by changing xml as well