Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor various classes relating to the Find Event Command #131

Merged
merged 23 commits into from
Nov 12, 2018
Merged

Refactor various classes relating to the Find Event Command #131

merged 23 commits into from
Nov 12, 2018

Conversation

vig42
Copy link

@vig42 vig42 commented Nov 11, 2018 •
edited
Loading

Also fix bug with ArgumentTokenizer, add tests and test cases for various classes

@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 333

  • 82 of 84 (97.62%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.06%) to 90.508%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/commons/events/ui/ToggleTabEvent.java 0 1 0.0%
src/main/java/seedu/address/model/Model.java 0 1 0.0%
Totals Coverage Status
Change from base Build 328: 1.06%
Covered Lines: 2174
Relevant Lines: 2402
💛 - Coveralls

@vig42 vig42 changed the title Refactor various classes relating to the Find Command Refactor various classes relating to the Find Event Command Nov 11, 2018
@vig42 vig42 self-assigned this Nov 12, 2018
@vig42 vig42 added this to the v1.4 milestone Nov 12, 2018
SleepySanjinLi
SleepySanjinLi reviewed Nov 12, 2018
View reviewed changes
Copy link

@SleepySanjinLi SleepySanjinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

src/test/java/systemtests/EditEventCommandSystemTest.java Show resolved Hide resolved
src/test/java/systemtests/FindEventCommandSystemTest.java Outdated Show resolved Hide resolved
@vig42 vig42 merged commit 7388f82 into CS2103-AY1819S1-T10-1:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySanjinLi SleepySanjinLi SleepySanjinLi left review comments

@pangjiahao pangjiahao pangjiahao left review comments

@bryanwongweiheng bryanwongweiheng Awaiting requested review from bryanwongweiheng

Assignees

@vig42 vig42

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@vig42 @coveralls @pangjiahao @SleepySanjinLi