Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests in TaskListPanel and ToDoListEevntCard #78

Merged
merged 21 commits into from
Nov 7, 2018

Conversation

SleepySanjinLi
Copy link

No description provided.

return "M";
} else {
return "L";
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this bug, I think we should probably refactor the Priority class instead.

I feel that it is more "correct" for the 'value' in the Priority class to be stored as "High", "Medium" or "Low" depending on the user input. This would probably cause a few other tests to fail also, but we need to properly refactor the code by week 13, so there's no other choice.

Ideally, we should use an enum to represent priority, but that would take even more work to modify everything.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can change if have time when everything is done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think enum (vig's suggestion) is necessary since we only have 3 possibilities.

@coveralls
Copy link

coveralls commented Nov 5, 2018

Pull Request Test Coverage Report for Build 264

  • 17 of 36 (47.22%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 86.712%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/ui/DescriptionDisplay.java 0 7 0.0%
src/main/java/seedu/address/logic/commands/ShowDescriptionCommand.java 10 22 45.45%
Totals Coverage Status
Change from base Build 262: -0.6%
Covered Lines: 2062
Relevant Lines: 2378

💛 - Coveralls

*/
public class ShowDescriptionCommand extends Command {

public static final String COMMAND_WORD = "show description";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like something like "show todo" would be a bit simpler, would also make it clear that it is a todo command.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@pangjiahao pangjiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
i guess we'll refactor the Priority thing once everything is finalized

@SleepySanjinLi SleepySanjinLi merged commit f8b16c4 into CS2103-AY1819S1-T10-1:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants