Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notebook to adapt to new RavenHydroFramework conventions #406

Closed
wants to merge 1 commit into from

Conversation

Zeitsperre
Copy link
Member

Fixes 1/2 of https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/12

FYI @tlvu

Changes

  • Updates the ForcingPetrurbation to use average temperature and not max and min temperature.

@Zeitsperre Zeitsperre added the documentation Improvements or additions to documentation label Oct 7, 2024
@Zeitsperre Zeitsperre requested review from huard and tlvu October 7, 2024 18:37
@Zeitsperre Zeitsperre self-assigned this Oct 7, 2024
@github-actions github-actions bot added the docs label Oct 7, 2024
@tlvu
Copy link
Collaborator

tlvu commented Oct 7, 2024

Cool, thanks ! I will test this with the new Jupyter env build. Please let me merge this PR so it is synchronized with the new Jupyter env go-live.

@coveralls
Copy link

Coverage Status

coverage: 81.343%. remained the same
when pulling a02c593 on fix-pjei-12-2
into 86d6306 on master.

@tlvu
Copy link
Collaborator

tlvu commented Oct 8, 2024

This PR has been merged into PR #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants