Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop navbar wrapping #293

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Stop navbar wrapping #293

merged 1 commit into from
Aug 11, 2022

Conversation

RogerGabeller-ml
Copy link
Contributor

this commit fixes #263

LMBishop
LMBishop approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@LMBishop LMBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future we may want to consider calculating this value rather than hard-coding it

MattyTheHacker
MattyTheHacker approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@MattyTheHacker MattyTheHacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculating would definitely be better I think but for the time being this is probably fine - potentially could be worth raising an issue to remind us.

@rainestormee
Copy link
Member

I think we merge this as a temporary fix but then not close the existing issue?

@LMBishop
Copy link
Contributor

I'll open a new issue for it

@LMBishop LMBishop changed the title Stopped navbar wrapping Stop navbar wrapping Aug 11, 2022
@LMBishop LMBishop merged commit f704397 into CSSUoB:master Aug 11, 2022
@LMBishop
Copy link
Contributor

(P.S. George, your git settings on your machine aren't properly configured so you might not receive contribution credit properly)

@LMBishop LMBishop mentioned this pull request Aug 11, 2022
Open
@RogerGabeller-ml RogerGabeller-ml deleted the navbar-wrapper branch August 19, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattyTheHacker MattyTheHacker MattyTheHacker approved these changes

@LMBishop LMBishop LMBishop approved these changes

@JTWWilson JTWWilson Awaiting requested review from JTWWilson

@Danyc0 Danyc0 Awaiting requested review from Danyc0

@rainestormee rainestormee Awaiting requested review from rainestormee

@sapphyree sapphyree Awaiting requested review from sapphyree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the header bar to a clickable menu when the width is low
4 participants
@RogerGabeller-ml @rainestormee @LMBishop @MattyTheHacker