Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25382] Added a sql test case for Support HASH JOIN with hint required #1936

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

junsklee
Copy link
Contributor

@junsklee junsklee commented Nov 4, 2024

Refer to http://jira.cubrid.org/browse/CBRD-25382.

Checklist before merge:

  • [x] --@full_plan keyword implementation CUBRIDQA-1236 in CTP has been merged.
  • DELETE statement support for query plan results CUBRIDQA-1239 has been merged (sql> run_cci cbrd_25382_2 fails without this fix).

### Answer file differences: Verified results vs CTP results using --@full_plan):
Note: Mostly numeric -> '?' conversions

cbrd_25382_1.answer (1_cost_diff): https://www.diffchecker.com/h1ETLq0c/
cbrd_25382_2.answer (2_delete_hint_diff): https://www.diffchecker.com/DQ9L1ULb/
cbrd_25382_3.answer (3_outer_join_diff): https://www.diffchecker.com/9vLg78Ki/
cbrd_25382_4.answer (4_select_hint_diff): https://www.diffchecker.com/LxQPlUVh/
cbrd_25382_5.answer (5_trace_diff): https://www.diffchecker.com/3ItiCaNT/ (section 7". ctes" is missing graph nodes and query plan results in the original file, but this error does not persist when using the --@full_plan keyword)
cbrd_25382_6.answer (6_update_hint_diff): https://www.diffchecker.com/mCcjIzLv/
cbrd_25382_7.answer (7_view_merging_diff): https://www.diffchecker.com/XVCp4g6X/

Answer file differences: Verified results vs CTP results using --@query_plan):

Note: Removal of Join graph data (retains query plans) & Numeric -> '?' conversions

cbrd_25382_1.answer (1_cost_diff_qp): https://www.diffchecker.com/CO2n8yWM/
cbrd_25382_2.answer (2_delete_hint_diff_qp): https://www.diffchecker.com/T3xSCUgl/
cbrd_25382_3.answer (3_outer_join_diff_qp): https://www.diffchecker.com/7A1flpi3/
cbrd_25382_4.answer (4_select_hint_diff_qp): https://www.diffchecker.com/IZEN0v1n/
cbrd_25382_5answer (5_trace_diff_qp): https://www.diffchecker.com/5OgJAdv0/ (section 7". ctes" is missing graph nodes and query plan results in the original file, but this error does not persist when using the --@full_plan keyword)
cbrd_25382_6.answer (6_update_hint_diff_qp): https://www.diffchecker.com/GjKrpuxx/
cbrd_25382_7.answer (7_view_merging_diff_qp): https://www.diffchecker.com/fgYhVk5h/

@junsklee junsklee marked this pull request as ready for review November 6, 2024 06:40
set @i = 0;

drop table if exists ta, tb, tc, td, t_bigint, t_numeric;
create table ta (ca int, cb int, cc int, cd int, index i1 (ca, cb, cc), index i2 (cb, cc), index i3 (cd));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

플랜에서 사용되는 인덱스를 구분할 수 있도록 인덱스명도 영문으로 사용하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정했습니다.

set @i = 0;

drop table if exists ta, tb, tc, td;
create table ta (ca int, cb int, cc int, cd int, index i1 (ca, cb, cc), index i2 (cb, cc), index i3 (cd));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

플랜에서 사용되는 인덱스를 구분할 수 있도록 인덱스명도 영문으로 사용하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정했습니다.

@junsklee junsklee requested a review from youngjinj November 13, 2024 07:37
@junsklee junsklee merged commit 4b83413 into CUBRID:develop Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants