Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects. #678

Merged

Conversation

jongmin-won
Copy link
Contributor

@jongmin-won jongmin-won commented Jul 25, 2024

http://jira.cubrid.org/browse/CBRD-25352

Built-in PL/CSQL을 호출할 때는 'dbms_output.'을 붙여야 정상 실행됩니다.
ex) 'call get_line;' -> 'call dbms_output.get_line;'

해당 PR이 merge되면 기존 phase-0가 merge된 develop branch에 영향을 미칩니다.
따라서 phase-1가 merge될 때까지 임시로 catch 문 안에서 DBMS_OUTPUT. 을 제거한 Built-in PL/CSQL을 한 번 더 수행하도록 CTE를 수정했습니다.

향후 phase-1 feature branch가 merge 되면 다시 제거할 계획입니다.

…_output.' to ensure normal execution. For example, 'call get_line;' -> 'call dbms_output.get_line;'
@jongmin-won jongmin-won marked this pull request as ready for review July 25, 2024 15:13
@jongmin-won jongmin-won self-assigned this Jul 25, 2024
@hgryoo
Copy link
Member

hgryoo commented Jul 26, 2024

  1. cci도 CTP와 같이 DBMS_OUPTUT을 인식하지 못하는 이전 버전에 대해서 우회가 필요해보입니다.
req = cci_prepare (conn, sql, CCI_PREPARE_CALL, &error);
  if (req < 0)
    {
      sql = "CALL GET_LINE (?, ?);"
      req = cci_prepare (conn, sql, CCI_PREPARE_CALL, &error);
      if (req < 0)
      {
        fprintf (stdout, "Set Server-Message Error:%d\n", error.err_code);
        fprintf (fp, "Set Server-Message Error:%d\n", error.err_code);
        res = -1;
        goto _END;
      }
    }
  1. Java 파일의 code style을 맞춰주세요.

…ovided a way to bypass it and adjusted the java code style.
@jongmin-won jongmin-won merged commit 53e9de2 into CUBRID:develop Jul 30, 2024
1 check passed
@jongmin-won jongmin-won deleted the feature/plcsql-CBRD-25352-testtools branch August 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants