forked from openedx/course-discovery
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in prior release changes from Feature/nutmeg.master/wordpress #26
Open
becdavid
wants to merge
42
commits into
develop/nutmeg.master
Choose a base branch
from
feature/nutmeg.master/wordpress
base: develop/nutmeg.master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates related sequentials when objectives are updated
Calculate the 'min_effort' and 'max_effort' for hidden sequentials and chapters for referenced posts.
- Update type error issue - Prevent including hidden from catalog courses in the `course-discovery` store or marketing frontend. - Update Course slug within the course meta data loader.
-Added delete functionality for Chapters should the LMS Block REST API not return a Chapter that already exists.
- Resolved `min_effort` and `max_effort` calculations when a Sequential is being saved to ensure it propagates up to both Chapter and CourseRun values too.
- Fixed the order of CourseRun and Chapter children to correct ordering on marketing frontend.
- Added support for `tags` to Sequentials, Chapters, and CourseRun models ensuring that they update the marketing Wordpress frontend
- Posted tags for Sequential, Chapter, and CourseRun to marketing frontend. Fix recursive issue when one of these models were saved in the admin form.
- Fix issue with `_update_tags` not working because model.id was not instantiated
- Fix issue where content was not being published to marketing frontend when Model status was set to a previous Unpublished state
- Updated related m2m Objectives when a Sequential model.save() call was issued for marketing frontend
- Added check to make sure that courses are hidden or removed from `course-discovery` store and marketing frontend.
- Limit the Course Run `short_description_override` text to 255 characters to avoid error with database save.
- Resolved issue when courses that were hidden were not getting deleted when checking to see if courses returned from LMS Courses REST service existed or not.
- Updated the course_run and course titles to remove the ':' prefix when saving into `course-discovery`
becdavid
force-pushed
the
feature/nutmeg.master/wordpress
branch
2 times, most recently
from
October 3, 2023 18:34
db797bd
to
4faae30
Compare
becdavid
force-pushed
the
feature/nutmeg.master/wordpress
branch
4 times, most recently
from
October 4, 2023 13:28
179576a
to
3d24bb2
Compare
becdavid
force-pushed
the
feature/nutmeg.master/wordpress
branch
from
October 4, 2023 13:41
3d24bb2
to
a0973a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.