-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend bar #53
Legend bar #53
Conversation
Deleting accidentally added output files.
Deleting accidentally added output files.
Well done! Some minor comments:
|
Jinning,
Ah, I was confused what the develop branch was for. I will do this in the
future.
Here is the full view of the placement of the legend.
[image: image.png]
As for the value ranges, thank you for catching this. I had mentally
skipped over the possibility and assumed the values were static. Just to
make sure I didn't miss anything, the range should correspond to the
frequency min and max values in the configuration panel?
I apologize for the mistake.
Thank you,
Zack
…On Wed, Aug 30, 2023 at 12:55 PM Jinning Wang ***@***.***> wrote:
Well done! Some minor comments:
1. In the future, newly developed features might be merged into develop
branch first, and we'll do the regular merge from branch to master
regularly. In this way, we can have a better release manner.
2. Would you mind putting a full screenshot here? So I can make sure
the overall layout is okay.
3. Are the range for the legend bar consistent with user settings?
—
Reply to this email directly, view it on GitHub
<#53 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2WS77CB4UCZRCA2HSHIONLXX5WA7ANCNFSM6AAAAAA4ERCU7U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
My practice would be to merge "patch" version
It didn't load the actual page but the file name here.
BTW, in the dynamic simulation, we have bus voltage, bus frequency, and bus angle. We might need to change the legend name accordingly if change the displayed variable. |
The image did not transfer correctly through email unfortunately. I have corrected the original image to show the full view.
I will make some event handlers to change the title and values as they get updated through use of the application. I will continue to work on this. I appreciate your feedback. |
Added a legend for the dynamic simulation. It now changes values based on the current state (v angle, v magnitude, and frequency).
Also cleaned up changed files and removed a redundant index.html file.
Default view
V Angle (min: -0.80, max: 0.2)
V Magnitude (min: -3.555 max: 3.01)
Frequency (min:0.9999 max: 1.0002)
Ability to be dragged