-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Js file commenting #58
Conversation
@@ -397,11 +473,14 @@ function addSidebarConfig(win, options, sidebar) { | |||
dt = dt.toUTCString(); | |||
|
|||
document.cookie = `opacity${win.num}=${val};expires=${dt};path=/`; | |||
|
|||
win.legend.update(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removed a line that was accidentally added when making the legend bar.
Zack, well done! I believe this can greatly improve the maintainability of AGVis. The blog link you insert seems to be invalid. Is there any automated tool can do this for your future development? If so, you can save manual efforts in the future. |
Sorry about that, I messed up the link placement. Its fixed now. I'm not sure if there are tools for auto commenting in this particular style, but it will be trivial to maintain this commenting style with future development anyways. |
No need to do this for all files in the future, just mark the most important files to your perspective. |
I have added developer comments for each AGVis js file. Each one includes a header that describes the author, date modified, description of the file, and a link to the API documentation. I mostly created header comments for each function per the following standard [ link ]. I also created breaks in logical code sections for readability. Finally, I reformatted the code styling (indentations mostly) to be consistent across all js files.