Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js file commenting #58

Merged
merged 28 commits into from
Sep 28, 2023
Merged

Js file commenting #58

merged 28 commits into from
Sep 28, 2023

Conversation

zmalkmus
Copy link
Collaborator

@zmalkmus zmalkmus commented Sep 28, 2023

I have added developer comments for each AGVis js file. Each one includes a header that describes the author, date modified, description of the file, and a link to the API documentation. I mostly created header comments for each function per the following standard [ link ]. I also created breaks in logical code sections for readability. Finally, I reformatted the code styling (indentations mostly) to be consistent across all js files.

@zmalkmus zmalkmus added the documentation Improvements or additions to documentation label Sep 28, 2023
@zmalkmus zmalkmus self-assigned this Sep 28, 2023
@@ -397,11 +473,14 @@ function addSidebarConfig(win, options, sidebar) {
dt = dt.toUTCString();

document.cookie = `opacity${win.num}=${val};expires=${dt};path=/`;

win.legend.update();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removed a line that was accidentally added when making the legend bar.

@jinningwang
Copy link
Member

Zack, well done! I believe this can greatly improve the maintainability of AGVis.

The blog link you insert seems to be invalid. Is there any automated tool can do this for your future development? If so, you can save manual efforts in the future.

@jinningwang jinningwang merged commit 4011728 into develop Sep 28, 2023
@zmalkmus
Copy link
Collaborator Author

Zack, well done! I believe this can greatly improve the maintainability of AGVis.

The blog link you insert seems to be invalid. Is there any automated tool can do this for your future development? If so, you can save manual efforts in the future.

Sorry about that, I messed up the link placement. Its fixed now.

I'm not sure if there are tools for auto commenting in this particular style, but it will be trivial to maintain this commenting style with future development anyways.

@jinningwang
Copy link
Member

Zack, well done! I believe this can greatly improve the maintainability of AGVis.
The blog link you insert seems to be invalid. Is there any automated tool can do this for your future development? If so, you can save manual efforts in the future.

Sorry about that, I messed up the link placement. Its fixed now.

I'm not sure if there are tools for auto commenting in this particular style, but it will be trivial to maintain this commenting style with future development anyways.

No need to do this for all files in the future, just mark the most important files to your perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants