Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Docker issue. #63

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fixed Docker issue. #63

merged 2 commits into from
Dec 15, 2023

Conversation

zmalkmus
Copy link
Collaborator

@zmalkmus zmalkmus commented Nov 3, 2023

I also added the ability to build different branches using ./go.sh build <BRANCH_NAME>

The one caveat of my workaround is that building the container takes a minute or two longer, however, it is guaranteed to not fail if the branch it is pulling from works correctly.

@zmalkmus zmalkmus self-assigned this Nov 3, 2023
@zmalkmus zmalkmus added the bug Something isn't working label Nov 3, 2023
@jinningwang
Copy link
Member

Ha, this is weird. I never run into such an issue before.

@jinningwang
Copy link
Member

On Mac, using with Docker, run into following error with go.sh. Terminal message is excerpted below. Not sure if this is a Mac issue or not.

(agvis) jinningwang@jwmba-3 agvis % agvis

    _   _____   ___     | Version 3.2.1.post54+gba53035
   /_\ / __\ \ / (_)___ | Python 3.11.3 on Darwin, 11/06/2023 06:40:53 AM
  / _ \ (_ |\ V /| (_-< | 
 /_/ \_\___| \_/ |_/__/ | Web-based geographical visualizer.

usage: agvis [-h] [-v {1,10,20,30,40}] {run,misc,selftest,st,demo} ...

positional arguments:
  {run,misc,selftest,st,demo}
                        [run] serve the web; [selftest] run self test;

options:
  -h, --help            show this help message and exit
  -v {1,10,20,30,40}, --verbose {1,10,20,30,40}
                        Verbosity level in 10-DEBUG, 20-INFO, 30-WARNING, or 40-ERROR.
(agvis) jinningwang@jwmba-3 agvis % ./go.sh clean
./go.sh: line 190: syntax error near unexpected token `newline'
./go.sh: line 190: `    google-chrome --incognito http://localhost:8810/ 2> /dev/null > /dev/null &!'
(agvis) jinningwang@jwmba-3 agvis % ./go.sh dev2
./go.sh: line 190: syntax error near unexpected token `newline'
./go.sh: line 190: `    google-chrome --incognito http://localhost:8810/ 2> /dev/null > /dev/null &!'

@zmalkmus
Copy link
Collaborator Author

zmalkmus commented Nov 7, 2023

On Mac, using with Docker, run into following error with go.sh. Terminal message is excerpted below. Not sure if this is a Mac issue or not.

(agvis) jinningwang@jwmba-3 agvis % agvis

    _   _____   ___     | Version 3.2.1.post54+gba53035
   /_\ / __\ \ / (_)___ | Python 3.11.3 on Darwin, 11/06/2023 06:40:53 AM
  / _ \ (_ |\ V /| (_-< | 
 /_/ \_\___| \_/ |_/__/ | Web-based geographical visualizer.

usage: agvis [-h] [-v {1,10,20,30,40}] {run,misc,selftest,st,demo} ...

positional arguments:
  {run,misc,selftest,st,demo}
                        [run] serve the web; [selftest] run self test;

options:
  -h, --help            show this help message and exit
  -v {1,10,20,30,40}, --verbose {1,10,20,30,40}
                        Verbosity level in 10-DEBUG, 20-INFO, 30-WARNING, or 40-ERROR.
(agvis) jinningwang@jwmba-3 agvis % ./go.sh clean
./go.sh: line 190: syntax error near unexpected token `newline'
./go.sh: line 190: `    google-chrome --incognito http://localhost:8810/ 2> /dev/null > /dev/null &!'
(agvis) jinningwang@jwmba-3 agvis % ./go.sh dev2
./go.sh: line 190: syntax error near unexpected token `newline'
./go.sh: line 190: `    google-chrome --incognito http://localhost:8810/ 2> /dev/null > /dev/null &!'

Interesting. It appears that it is trying to run ./go.sh dev or a similar command even though you used the clean command. Whoever added stuff to go.sh before me added some '!' characters at the end of commands, which is not correct syntax but still somehow manages to get past my Ubuntu OS. I removed the rest of them and pushed the quick fix, but that should not be causing the issue here. I will do some more testing on the branch and find out what is wrong.

@zmalkmus
Copy link
Collaborator Author

zmalkmus commented Nov 7, 2023

The issue was created from the Darwin OS not compiling due to syntax errors that only Darwin is picking up. Bash scripts are single-pass interpreted (checks and runs one command at a time instead of precompiling the file) so it is weird that Darwin OS is picking up an error in another function. Anyways, it should be fixed now on this branch. Let me know if the issue is still happening.

@jinningwang
Copy link
Member

Feel free to merge it when available.

@zmalkmus zmalkmus merged commit edc350d into develop Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants