Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my portfolio #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added my portfolio #3

wants to merge 1 commit into from

Conversation

rhoadsa81
Copy link

No description provided.

@J3RN
Copy link
Contributor

J3RN commented Sep 3, 2015

Hey, nice portfolio site! 👍 I noticed, though, that it doesn't have any italicized text, a list, or a link to another website. Would you mind adding those?

@rhoadsa81
Copy link
Author

So theoretically wouldn't the "Engineering" "Side Projects" and "Technical" links be links that go to another website?

@J3RN
Copy link
Contributor

J3RN commented Sep 4, 2015

The phrasing here gets a little ambiguous - sorry about that. I'd say that the "Engineering", etc files are different "web pages" that make up your portfolio "website." The reasoning behind requiring links to both other pages and other sites was that the way you write the tags is a little different, in that links to other websites require you to write href="http://..." vs href="engineering.html" for other pages.

I hope that helps! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants