-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audience is endpoint dependent. #430
Conversation
I really don't care if the coverage decreases with 0.001 % . |
algorithm = None | ||
if kwargs['authn_endpoint'] in ['token', 'refresh']: | ||
try: | ||
algorithm = self.cli.registration_info[ | ||
'token_endpoint_auth_signing_alg'] | ||
except (KeyError, AttributeError): | ||
pass | ||
audience = self.cli.provider_info['token_endpoint'] | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The drop in coverage is caused by this branch, which is never covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can easily be remedied
I don't think this will break anything. It's really a corner case, slightly outside the standard. |
Thanks for contributing to this library! Please include the following check
list in your pull request submission (you can delete this message). If your
changes don't need a change log or documentation update, please ignore this.
CHANGELOG.md
.