grant_types should follow response_types in a client registration req… #493
Conversation
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ The format is based on the [KeepAChangeLog] project. | |||
| ## 0.13.0 [Unreleased] | |||
|
|
|||
| ### Added | |||
| - [#493] grant_types specification should follow the response_types sprecification in a client registration request. | |||
There was a problem hiding this comment.
specification, not sprecification
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 59% 59.04% +0.04%
==========================================
Files 62 62
Lines 11200 11214 +14
Branches 1957 1959 +2
==========================================
+ Hits 6608 6621 +13
Misses 4036 4036
- Partials 556 557 +1
Continue to review full report at Codecov.
|
| } | ||
|
|
||
|
|
||
| def response_types_to_grant_types(response_types): |
There was a problem hiding this comment.
This should be covered by tests.
There was a problem hiding this comment.
Especially the part that response_types may be in random order (so no one removes the 'sort' from the code by accident).
There was a problem hiding this comment.
One last thing then this is good to go.
The test with an unknown response_type should also be present.
src/oic/oic/__init__.py
Outdated
| @@ -1319,6 +1345,12 @@ def create_registration_request(self, **kwargs): | |||
| except KeyError: | |||
| pass | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
I think it is better to change try .. except to a condition if response_types in req.
There was a problem hiding this comment.
I'm OK with either or so we'll go for your proposal.
CZ-NIC#493) * grant_types should follow response_types in a client registration request.
grant_types should follow response_types in a client registration request
CHANGELOG.md.