Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add token_type checks a required parameter alongside of an access_token #565

Merged
merged 4 commits into from
Sep 3, 2018
Merged

add token_type checks a required parameter alongside of an access_token #565

merged 4 commits into from
Sep 3, 2018

Conversation

zandbelt
Copy link
Contributor

@zandbelt zandbelt commented Sep 2, 2018 •
edited
Loading

Signed-off-by: Hans Zandbelt hans.zandbelt@zmartzone.eu

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

@zandbelt
add token_type checks a required parameter alongside of an access_token
a7d1401 
Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
@zandbelt zandbelt mentioned this pull request Sep 2, 2018
Closed
@zandbelt
address QA issues for token_type checks
d9eaa7d 
Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
@codecov-io
Copy link

codecov-io commented Sep 2, 2018 •
edited
Loading

Codecov Report

Merging #565 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #565      +/-   ##
=========================================
+ Coverage   59.79%   59.8%   +0.01%     
=========================================
  Files          62      62              
  Lines       11253   11256       +3     
  Branches     1982    1984       +2     
=========================================
+ Hits         6729    6732       +3     
  Misses       3968    3968              
  Partials      556     556
Impacted Files Coverage Δ
src/oic/oic/message.py 62.36% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad1cdb...953a18b. Read the comment docs.

tpazderka
tpazderka requested changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a line to the changelog?

Otherwise it looks good to me.

@zandbelt
record #565 in ChangeLog
953a18b 
Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
@tpazderka tpazderka merged commit eced88c into CZ-NIC:master Sep 3, 2018
@zandbelt zandbelt deleted the add-token_type-checks branch September 3, 2018 09:24
andrewkrug pushed a commit to mozilla-iam/pyoidc that referenced this pull request Jun 6, 2019
@zandbelt @andrewkrug
Add token_type checks a required parameter alongside of an access_tok…
175d4d2 
…en (CZ-NIC#565)

add token_type checks a required parameter alongside of an access_token

Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpazderka tpazderka tpazderka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zandbelt @codecov-io @tpazderka