Skip to content

Commit

Permalink
f2fs: don't handle error case of f2fs_compress_alloc_page()
Browse files Browse the repository at this point in the history
f2fs_compress_alloc_page() uses mempool to allocate memory, it never
fail, don't handle error case in its callers.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
chaseyu authored and Jaegeuk Kim committed Aug 14, 2023
1 parent 579c7e4 commit 863907a
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions fs/f2fs/compress.c
Original file line number Diff line number Diff line change
Expand Up @@ -649,13 +649,8 @@ static int f2fs_compress_pages(struct compress_ctx *cc)
goto destroy_compress_ctx;
}

for (i = 0; i < cc->nr_cpages; i++) {
for (i = 0; i < cc->nr_cpages; i++)
cc->cpages[i] = f2fs_compress_alloc_page();
if (!cc->cpages[i]) {
ret = -ENOMEM;
goto out_free_cpages;
}
}

cc->rbuf = f2fs_vmap(cc->rpages, cc->cluster_size);
if (!cc->rbuf) {
Expand Down Expand Up @@ -1574,8 +1569,6 @@ static int f2fs_prepare_decomp_mem(struct decompress_io_ctx *dic,
}

dic->tpages[i] = f2fs_compress_alloc_page();
if (!dic->tpages[i])
return -ENOMEM;
}

dic->rbuf = f2fs_vmap(dic->tpages, dic->cluster_size);
Expand Down Expand Up @@ -1656,11 +1649,6 @@ struct decompress_io_ctx *f2fs_alloc_dic(struct compress_ctx *cc)
struct page *page;

page = f2fs_compress_alloc_page();
if (!page) {
ret = -ENOMEM;
goto out_free;
}

f2fs_set_compressed_page(page, cc->inode,
start_idx + i + 1, dic);
dic->cpages[i] = page;
Expand Down

0 comments on commit 863907a

Please sign in to comment.