Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a new Report Template, save fails and loses all data #41

Closed
netniV opened this issue Sep 6, 2018 · 5 comments
Closed

Comments

@netniV
Copy link
Member

netniV commented Sep 6, 2018

Given the following configuration:
image

When clicking Create, you will receive

image

Therefore, the lock should be applied by default. The only thing I changed to make this save was to click the Locked toggle. Additionally, only Name and Additional Pre-Filter keep their settings as all other entries fields lose their settings as a result of this failure.

@ikorzha
Copy link

ikorzha commented Sep 21, 2018

netniV, I was facing the same issue until i stumbled on your post.. Is there a way you can apply a fix to this problem?

@netniV
Copy link
Member Author

netniV commented Sep 21, 2018

Maybe, but I think the default was removed recently. I will need to double check with @browniebraun on that since he's the creator/master of this ;-)

@netniV
Copy link
Member Author

netniV commented Sep 21, 2018

So, I was right, I did see a change relating to that which was 498a714 which was part of PR #16 by @Carlimeunier but it would appear that the 'locked' change is incorrect. If @browniebraun doesn't have an update, I can look at repairing it.

@netniV netniV changed the title New Report, Save fails and loses all data When creating a new Report Template, save fails and loses all data Sep 21, 2018
netniV added a commit that referenced this issue Sep 21, 2018
@netniV
Copy link
Member Author

netniV commented Sep 21, 2018

So I went ahead and readded the automatic 'locked' status. This should now be resolved.

@netniV netniV closed this as completed Sep 21, 2018
@ikorzha
Copy link

ikorzha commented Sep 21, 2018

netniV, can you for the fix. Can you please take a look at issue #44
It is a next step in creating report that doesn't work in my opinion. Looking for your advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants