-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more types to duplication plugin #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in support for meshes, textures, object variations blueprint bundles and(hopefully) subworlds to be duplicated
Replace some of my stuff with mophead's since thats not working(thank you mophead <3)
Added support for atlas texture assets, fixed some issues(primarily it adding res and chunks to a bundle twice and the BPB duplication being set to the wrong bundle type) I have also started work on duplicating Object Variations though that isn't working currently for SWBF2 for other games its fine but for SWBF2 it will work until you change a texture param, if a texture param is modified then I think the SBD breaks, or its broken the moment its created and only corrupts after the texture param is changed something along those lines(perhaps the variation name hash isn't being fed into it correctly, and thats the cause? Should double check everything relating to the variation name hash). Will try to work on this tomorrow when I wake up
wannkunstbeikor
requested changes
Aug 10, 2023
This adds in support for FindVariations not being able to search for modified Variations, as well as adds a bool to toggle this(so if you have a off case where you explicitly don't want modified/duped variations you can tell it not to)
This allows object variations to be fully duplicated, The Object Variation editor was modified so that it could support writing to new variations(using my previous commit) also added in a no valid MVDB error so when you dupe a object variation and don't add it to MVDBs it'll complain Also addressed requests cited
wannkunstbeikor
requested changes
Aug 10, 2023
Add duplication support for the 2 cloth types
I forgot to upload this earlier with my other stuff, this is just updated to match your requests
sorry this took so long I was busy with something else
This fixes a bug where Task Window will always display "loading variation Databases" even during the actual duplication process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for lots of types with chunks and res, as well as support for BPBs and subworlds(along side creating new bundles for them)
Will commit/PR stuff for Atlas textures and ObjectVariations later too