[Mod Manager] Improvements to Collection Import #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dyvinia
commented
Sep 26, 2023
•
Dyvinia
commented
- Improvements to Collection import
- Collections can now be imported even if they are not in an archive
- Alerts user if trying to drag in mod files from inside of an archive (such as drag/drop from winrar/7zip etc
Dyvinia
changed the title
|
Had to put the 2 changes into one PR since they both edit the same area |
Dyvinia
changed the title
| { | ||
| string[] filenames = (string[])e.Data.GetData(DataFormats.FileDrop, true); | ||
| InstallMods(filenames); | ||
|
|
||
| ICollectionView view = CollectionViewSource.GetDefaultView(availableModsList.ItemsSource); | ||
| view.Refresh(); | ||
| } | ||
| else if (e.Data.GetFormats().Any(f => f == "FileContents")) |
There was a problem hiding this comment.
does that not write them to the tmp storage and then u should be able to import them anyways?
There was a problem hiding this comment.
windows zip doesnt, winrar however does and it will satisfy the first if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.