Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config API and Options Screen Redesign #2837

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from
Open

Config API and Options Screen Redesign #2837

wants to merge 43 commits into from

Conversation

douira
Copy link
Collaborator

@douira douira commented Oct 24, 2024 •
edited
Loading

Also thanks to @KingContaria for writing code on which I based the forge mod config entrypoint loader. @IMS212 wrote the initial redesign of the options page.

There's a bunch of TODOs in the code that I want to address. Feel free to help me with them and I'll merge them into this PR.

The design of the page as well as the outwards facing API are open to feedback and remain subject to change until release.

fixes #2309
fixes #2831

@douira douira mentioned this pull request Oct 27, 2024
Merged
@douira
Copy link
Collaborator Author

douira commented Nov 3, 2024

After implementing dynamic value constraints in the slider and cycler control elements, the remaining TODOs are not necessary for the basic required features to work and it's ready for review. The requests for additions to the API were implemented.
The search bar is not yet functional, but we can simply remove that without regressing the UX and add it when it gets implemented later. @KingContaria mentioned he wanted to work on the tooltip scroller and I plan on slowly working through the other remaining non-essential TODOs, which are related to UX/UI.
One thing I can't do and should be clarified before we release, is the automatic import of vanilla options into our options screen that @IMS212 had prototyped. I don't have that code but would integrate it if provided with it.

@douira douira marked this pull request as ready for review November 3, 2024 04:16
@douira douira requested a review from jellysquid3 November 3, 2024 04:16
@douira
Copy link
Collaborator Author

douira commented Nov 26, 2024

I've been provided by IMS's code to import vanilla options but haven't worked through that yet. @KingContaria contributed scrollable tooltips and I further reworked tooltip and donation button rendering.

IMS212 and others added 23 commits November 27, 2024 23:40
@IMS212 @douira
New game GUI experiment
2dd748c
@douira
Add WIP config api with IMS' redesign of the options page and contari…
286a89b 
…a's forge mod entrypoint loader code
@douira
scrollabe page list
59248f5 
authored by @KingContaria
@douira
allow users to set their own theme colors,
5826086 
fix some issues when text is too long
@douira
add api to add custom screens, use a color theme builder instead of a…
a25fcaf 
… direct method
@douira
move important members of option builder subinterfaces more useful
6d860ee
@douira
refactor: store dimensions in AbstractWidget
75d04e8 
Co-authored-by: contaria <kingcontaria@gmail.com>
@douira
new: scrollable option list
0a8451c 
Co-authored-by: contaria <kingcontaria@gmail.com>
@douira
fix: move sliders and tickboxes when sccrolling
eed37da 
Co-authored-by: contaria <kingcontaria@gmail.com>
@douira
add api method for formatting version instead of setting a new one
214e69d
@douira
fix crash not working correctly
a36c2cf
@douira
move layout constants into separate class,
7abd22e 
fix gradient behind sidebar,
change layout of buttons and options panes,
fix overlapping ui elements,
fix scissor areas,
make spacings and arrangement consistent
@douira
constrain tooltip to screen
319586a
@douira
fix tooltip after rebase
77b3ebf
@douira
improve config failure crash message
0486a0b
@douira
add default implementation to early register entrypoint so users don'…
7723e38 
…t need to implement both entrypoints even if they only need the late ("main") one
@douira
truncate mod header subtitles if too long
f3cba52
@douira
add usage documentation, update todos
d78a2c6
@douira
add api methods to add button that redirects to an external page
d60e9f7
@douira
allow gui scale to be changed by holding down control and scrolling,
ccce373 
refactor option applying, move flag processing into Config,
@douira
add ability for mods to override other mods' options with new options
be0526f
@douira
cleanup
66b0b8c
@douira
implement dynamic value constraints in control elements, cleanup cont…
1d2c262 
…rol elements
douira added 12 commits November 28, 2024 00:09
@douira
move builder impls into separate package
3e477c6
@douira
add page list width constant
0688f1a
@douira
add search index interface and bigram search index implementation
9d7e1b4
@douira
move search button to top of page list
2d3e970
@douira
add search widget that turns search button into a text box with a clo…
a0bcd5e 
…se button,

other refactoring around page and option list layouts
@douira
remove search result class and move score into text source,
657ffbf 
this simplifies a number of operations around the search result processing.
also added more context to the text source objects
@douira
make page list highlight more visible
24154d3
@douira
make the search results actually ordered
561ab59
@douira
use option page instead of just page as the metadata on text sources …
ca6a231 
…from options
@douira
use abstract option list instead of concrete option list where possible
b63bea6
@douira
add search results with page list and clickable page list items
e441260
@douira
fix some focus issues with the search box
a7c1b56
@jellysquid3 jellysquid3 added this to the Sodium 0.7 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellysquid3 jellysquid3 Awaiting requested review from jellysquid3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sodium 0.7
5 participants
@douira @jellysquid3 @IMS212 @haykam821 @KingContaria