TR Orbit and Impact velocity additions #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I figured out how to point this at you @CalebJ2. Hopefully you can merge this to your branch and then merge it to the main KOS branch from there before your pull request KSP-KOS#1603 gets closed. I modified the wrapper, the addon, and the documentation. I think that is everything. I am not really familiar with C# so I copied all of your conventions on class naming/variable and function declaration and so on. I am like that "I have no idea what I'm doing" dog meme.
Also, I am unsure if the spaceorbit really needs to say in the KOSexception that you should always check hasimpact in the addon file because it could be possible to have a modified orbit due to aerobreaking but not have an impact. I don't know what else to do for an exception there though because idk if those patch instances will always have orbits in them or not.