Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto splitter advanced for huggingface config #220

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Add auto splitter advanced for huggingface config #220

merged 6 commits into from
Mar 12, 2024

Conversation

ZHIHANCHEN03
Copy link
Contributor

No description provided.

goldmermaid
goldmermaid approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@goldmermaid goldmermaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldmermaid
Copy link
Collaborator

Great work @ZHIHANCHEN03 . One small comment, you can remove load_dotenv() for any huggingface notebook in the future.

@goldmermaid goldmermaid merged commit 1ff1a6a into CambioML:main Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmermaid goldmermaid goldmermaid approved these changes

@CambioML CambioML Awaiting requested review from CambioML CambioML is a code owner

@SayaZhang SayaZhang Awaiting requested review from SayaZhang SayaZhang is a code owner

@CluckRookie CluckRookie Awaiting requested review from CluckRookie CluckRookie is a code owner

@SeisSerenata SeisSerenata Awaiting requested review from SeisSerenata SeisSerenata is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZHIHANCHEN03 @goldmermaid