-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a simpler PenguinDataset in Exercise 1 notebook #73
Conversation
@jatkinson1000 would you prefer the jupyter notebook outputs to be retained? |
bb826e4
to
a0b7f55
Compare
Jack confirmed that we should retain the cell outputs of the solutions notebook for reference. |
…taset defined within the notebook itself
…n optional exercise
4aed474
to
da3e1ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks sensible to me in theory @ma595
Caveat that I have not run the code and will leave this (and approval) to @surbhigoel77 as the co-presenter.
I agree that it would be easier to move changes to the colab branch after merging to main.
Also consider how other exercises might need adapting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs fine for me,
This PR creates a simpler
PenguinDataset
within theworked-solutions/01_penguin_classification_solutions.ipynb
notebook.Within this easier PenguinDataset we:
_load_penguin_data(...)
and_split_data(...)
into__init__()
lambdas
andCompose
object, making it easier to follow.Other notebook changes include:
_penguins.py
has been referenced in the notebook as an example of good software practice.Compose
has been removed.Before merging, the following tasks must be completed:
Propagate changes to:
Closes #71