-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest.json to support Thunderbird Supernova #56
Conversation
Bump `strict_max_version` to `115.*`
I prematurely updated to Supernova, which does not support the official Because my workflow requires this great extension I tried to get it running under Supernova. This is the minimum change required. I was happy that I did not have to tinker with Anyway I could get a working Supernova extension. |
Hi, After installing the new release with this patch, I am able to copy a thunderlink from TB, but I am unable to paste-and-jump to a thunderlink, neither using the cb_thunderlink button in TB nor the plugin shortcut. It used to work pre-115.*. TB basically shows a "nounDef is undefined" error from line 69 in cb_api.js, which calls newQuery on line 1832 of Gloda.jsm, see this screenshot with the full stacktrace: https://www.dropbox.com/scl/fi/09ypnhtizp0fc3w61rp9a/SCR-20230717-w2v.png?rlkey=cctqu6qq0ed0awqacxpqbbwj7&dl=0. Rebuilding the global index does not seem to fix the issue. @CodeJordan23 : Are you able to paste a link in TB and jump to that email? |
Hi, Following in background (I am not yet on 115 and thus cannot reproduce). Camiel B. |
Thanks for the quick reply. Yes, searching on the subject of that email works within TB, and using sqlite3 on global-messages-db.sqlite I can retrieve the email information based on the message id. I'll try to poke some more. |
Can you insert some console.log messages to identify which call actually fails? is it the Gloda.newQuery? I am still suspecting some change in the gloda that interferes. |
Hi @CamielBouchier, I fixed the issue in cb_api.js, will send a pull request. |
This is a fix for the issue discussed in CamielBouchier#56 where trying to open an email based on its message ID, either through the plugin button or the shortcut leads to "Uncaught TypeError: nounDef is undefined". Apparently, NOUN_MESSAGE should now be found in gloda/GlodaConstants.jsm instead of in gloda/GlodaPublic.jsm or gloda/public.js.
After merging in I needed to change it a bit to stay compatible with pre-115 versions. |
Hi @CamielBouchier , yes the updated code still works on 115, thanks for making the modifications. |
@bramadams : Thanks for the confirmation! Will make a new release next couple of days. |
Bump
strict_max_version
to115.*