Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json to support Thunderbird Supernova #56

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

CodeJordan23
Copy link
Contributor

Bump strict_max_version to 115.*

Bump `strict_max_version` to `115.*`
@CodeJordan23
Copy link
Contributor Author

I prematurely updated to Supernova, which does not support the official cb_thunderlink extension yet.

Because my workflow requires this great extension I tried to get it running under Supernova. This is the minimum change required. I was happy that I did not have to tinker with manifest_version and permissions 😅.

Anyway I could get a working Supernova extension.

@CamielBouchier CamielBouchier merged commit 531d589 into CamielBouchier:main Jul 17, 2023
@bramadams
Copy link
Contributor

bramadams commented Jul 18, 2023

Hi,

After installing the new release with this patch, I am able to copy a thunderlink from TB, but I am unable to paste-and-jump to a thunderlink, neither using the cb_thunderlink button in TB nor the plugin shortcut. It used to work pre-115.*.

TB basically shows a "nounDef is undefined" error from line 69 in cb_api.js, which calls newQuery on line 1832 of Gloda.jsm, see this screenshot with the full stacktrace: https://www.dropbox.com/scl/fi/09ypnhtizp0fc3w61rp9a/SCR-20230717-w2v.png?rlkey=cctqu6qq0ed0awqacxpqbbwj7&dl=0.

Rebuilding the global index does not seem to fix the issue.

@CodeJordan23 : Are you able to paste a link in TB and jump to that email?

@CamielBouchier
Copy link
Owner

CamielBouchier commented Jul 18, 2023

Hi,

Following in background (I am not yet on 115 and thus cannot reproduce).
Based on my reading of the stacktrace I wonder if it's really an issue of cb_thunderlink.
My first suggestion would be: does a manual search for the message-id (or any other feature of the message) work?
Let me know if I can be of any help ...

Camiel B.

@bramadams
Copy link
Contributor

Thanks for the quick reply.

Yes, searching on the subject of that email works within TB, and using sqlite3 on global-messages-db.sqlite I can retrieve the email information based on the message id. I'll try to poke some more.

@CamielBouchier
Copy link
Owner

Can you insert some console.log messages to identify which call actually fails?

is it the Gloda.newQuery?
Or the headerMessageId?
Or the getCollection?

I am still suspecting some change in the gloda that interferes.
@CodeJordan23: any insights from your end, does it work?

@bramadams
Copy link
Contributor

Hi @CamielBouchier, I fixed the issue in cb_api.js, will send a pull request.

bramadams added a commit to bramadams/cb_thunderlink that referenced this pull request Jul 18, 2023
This is a fix for the issue discussed in CamielBouchier#56 where trying to open an email based on its message ID, either through the plugin button or the shortcut leads to "Uncaught TypeError: nounDef is undefined".

Apparently, NOUN_MESSAGE should now be found in gloda/GlodaConstants.jsm instead of in gloda/GlodaPublic.jsm or gloda/public.js.
@CamielBouchier
Copy link
Owner

After merging in I needed to change it a bit to stay compatible with pre-115 versions.
Can you check if the result still works for you now?
Camiel B.

@bramadams
Copy link
Contributor

Hi @CamielBouchier , yes the updated code still works on 115, thanks for making the modifications.

@CamielBouchier
Copy link
Owner

@bramadams : Thanks for the confirmation! Will make a new release next couple of days.
Camiel B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants