Static fun java #111
Closed
Static fun java #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canato
approved these changes
Apr 12, 2021
Canato
requested changes
Apr 12, 2021
There was a problem hiding this comment.
@prashant-13 Since we had to open a second one because of more notations need. Would you have time to create a Sample in Java code? So we can be sure that is working?
In Kotlin we have 3 samples, you could get only the one who use CropImage.activity
|
This PR is missing functions, for example Let's merge this when we have a Java Sample code, so we can be sure about the usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #108
Not able to access CropImage.activity() function in Java class
Cause:
Not added @JvmStatic annotation in static function in CropImage
How the bug was solved:
Added @JvmStatic annotation in all static function in CropImage